jens
/
ansible-role-drone
1
0
Fork 1
Code Issues Pull Requests Releases Wiki Activity

fix_linting #5

Merged
jens merged 8 commits from eludum/ansible-role-drone:fix_linting into main 2021-08-26 16:14:39 +00:00
Conversation 0 Commits 8 Files Changed 2 +44 -26
eludum commented 2021-08-26 13:29:45 +00:00
Contributor
Copy Link
No description provided.
eludum added 2 commits 2021-08-26 13:29:45 +00:00
jens reviewed 2021-08-26 13:33:57 +00:00
tasks/main.yml
@ -44,3 +44,3 @@
args:
chdir: "{{ drone_home }}/drone/cmd/drone-server"
when: gitclone.changed
when: gitclone.changed # noqa no-handler
jens commented 2021-08-26 13:33:57 +00:00
Owner
Copy Link

why?

why?
eludum commented 2021-08-26 14:58:19 +00:00
Author
Contributor
Copy Link

I can't see a clean solution to this, so linting ignore it is.

I can't see a clean solution to this, so linting ignore it is.
jens commented 2021-08-26 16:20:16 +00:00
Owner
Copy Link

why can't we do a notify after git clone?

why can't we do a notify after git clone?
eludum added 1 commit 2021-08-26 13:34:09 +00:00
jens reviewed 2021-08-26 13:53:09 +00:00
tasks/main.yml Outdated
@ -58,0 +56,4 @@
- name: "Unzip runner"
unarchive:
src: "{{ drone_home }}/{{ item }}"
dest: /usr/local/bin/
jens commented 2021-08-26 13:53:09 +00:00
Owner
Copy Link

will this cleanly unzip?
I think the tar.gz structure is a folder named drone_runner_exec_linux_amd64 containing the binary

will this cleanly unzip? I think the tar.gz structure is a folder named drone_runner_exec_linux_amd64 containing the binary
eludum commented 2021-08-26 14:59:21 +00:00
Author
Contributor
Copy Link

This change was made to include the tar that only contains the binary. This looked cleaner and fixed a linting issue with git clone, this way also you don't have to specify the version it downloads the latest

This change was made to include the tar that only contains the binary. This looked cleaner and fixed a linting issue with git clone, this way also you don't have to specify the version it downloads the latest
jens commented 2021-08-26 15:20:33 +00:00
Owner
Copy Link

ok, but it doesn't work this way?

This will result in /usr/local/bin/drone_runner_exec_linux_amd64/drone-runner-exec which is not in PATH?

ok, but it doesn't work this way? This will result in `/usr/local/bin/drone_runner_exec_linux_amd64/drone-runner-exec` which is not in `PATH`?
jens marked this conversation as resolved
jens added 1 commit 2021-08-26 15:19:24 +00:00
jens added 4 commits 2021-08-26 16:14:29 +00:00
jens merged commit c6c3fc73b2 into main 2021-08-26 16:14:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jens/ansible-role-drone#5
No description provided.
Delete Branch "eludum/ansible-role-drone:fix_linting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?